![]() | This is an archive of past discussions on Wikipedia talk:WikiProject Articles for creation/Helper script/Rewrite. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 1 | Archive 2 |
{{resolved}}
Review this submission should not appear if(mw.config.get('wgPageContentModel') !== 'wikitext'). There is no reason for the script to appear on userjscss pages... — {{U|Technical 13}} (t • e • c) 02:15, 14 March 2014 (UTC)
{{resolved}}
If all you care about is template names and their parameters, you could have avoided using Parsoid and use rvgeneratexml
instead. See mw:User:Kephir/XML parse tree for the parse tree format. Keφr 06:22, 14 March 2014 (UTC)
Kephir Spent my afternoon doing some serious speed tests. It looks like even with the additional requests in the future (metadata, categories, etc.), using the api itself rather than Parsoid is still faster. So... I've implemented it! Your guide was extremely helpful, and the script is significantly sped up as a result. Just goes to show that shiny new features aren't always better. (The funny thing is, I was working on Special:ExpandTemplates in MediaWiki itself recently...implemented the HTML preview functionality... and still didn't remember that you could get the XML parse tree...*sigh*). Again, thank you. :) Theopolisme (talk) 01:25, 15 March 2014 (UTC)
{{resolved}}
Accept button returns no action with "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" as an error message in the console. Decline and Comment do work, but visually need a bottom border as the letters are too hard to read with the bottom of them bleeding into the white space below. — {{U|Technical 13}} (t • e • c) 12:51, 14 March 2014 (UTC)
window.localStorage
object to see what is currently stored. Theopolisme (talk) 20:36, 14 March 2014 (UTC)localStorage.removeItem( 'key' )
. Theopolisme (talk) 21:49, 14 March 2014 (UTC){{resolved}}
Declining hangs with "Use of mediawiki.api callback params is deprecated. Use the Promise instead." It does say that it "Saved Draft:" and "Saved User talk:" which are confirmed in [1] and [2] respectively. — {{U|Technical 13}} (t • e • c) 12:57, 14 March 2014 (UTC)
var api = new mw.Api();
// the old way to do it, deprecated
api.get( { action: 'query' }, function ( data ) { console.log( data ) } );
// as opposed to the new way using a $.Promise
api.get( { action: 'query' }.done( function ( data ) { console.log( data ) } );
alert(navigator.userAgent);
returns Mozilla/5.0 (Windows NT 6.0; rv:27.0) Gecko/20100101 Firefox/27.0
{{resolved}}
Declining posted the template on the user's talk page, but did not give it a header. — {{U|Technical 13}} (t • e • c) 13:32, 14 March 2014 (UTC)
{{resolved}}
I am posting this feedback from Wikipedia:Miscellany for deletion/User:TheShadowCrow/sandbox/Youri Raffi Djorkaeff and I'm entirely unsure of how the script is running on this page (I can't see it in the coding). — {{U|Technical 13}} (t • e • c) 12:48, 16 March 2014 (UTC)
The rewrite is not patrolling pages and I'm having to go back and do it manually. This is annoying and wasting time that I could be spending reviewing... — {{U|Technical 13}} (t • e • c) 18:52, 17 March 2014 (UTC)
{{resolved}}
I'm approving Roger's template submission for WP:WikiProject Disability and when I try to enter the WikiProject in the WikiProject line, it rejects it since it is not on the list. There has to be a better way to do this. It should be able to pass whatever is in the input line through as if it was on the list even if it isn't. The "list" should only be for assisting people in finding a specific project or if there is questionable case or spelling. There should also be a log page of all WikiProjects entered on that line that are not on the current list which would allow for addition of those projects to the list if they are used enough. — {{U|Technical 13}} (t • e • c) 14:14, 20 March 2014 (UTC)
{{resolved}}
See this accepted disambig for details. — {{U|Technical 13}} (t • e • c) 20:38, 20 March 2014 (UTC)
{{resolved}}
Version 0.5 has been released. It includes G13 functionality, custom WikiProject tagging, and a number of other improvements, tweaks, and fixes. Give it a whirl if you're so inclined! :) Theopolisme (talk) 03:04, 22 March 2014 (UTC)
{{resolved}}
Hello - trying out the new AFCH interface. It might be nice to have the script do a check, and if the name of the article is "sandbox", not send a message counting how many times that article name has been deleted. —Anne Delong (talk) 22:15, 22 March 2014 (UTC)
{{resolved}}
Hello - first reviewing experience: I want to mark a submission as being reviewed, but the option was hidden. I clicked on the arrow to reveal the option, but my aim was a little off and I ended up clicking on the edge of the "Comment" box. I didn't want to post a comment, but the other options were no longer visible. I tried the back button, but that took me to a previous page. I solved the problem with a reload and started over. On second try I was able to mark the submission as under review. I suppose the big buttons are for people with tiny screens..... —Anne Delong (talk) 22:45, 22 March 2014 (UTC)
Thanks for your feedback. I've attempted to make the back link more noticeable; please let me know your thoughts. (Note that to do this I removed the feedback link, but I'll be looking into how to reinstate it shortly...) Theopolisme (talk) 17:02, 23 March 2014 (UTC)
{{resolved}}
I completed a review. I like the way that you have indented the items on the decline reason list - it solves something that I complained about in the old script - difficulty in spotting the reason I wanted in a long list in which I couldn't distinguish the headings from the items. —Anne Delong (talk) 01:04, 23 March 2014 (UTC)
{{resolved}}
Hello again. This time I am looking at G13 eligible submissions. I didn't see a "Postpone" function, so I tried to use my touch screen to go to the hidden options to see if it was there. I managed to accidentally nominate the page for deletion, since that was the rightmost option (sigh). —Anne Delong (talk) 03:14, 23 March 2014 (UTC)
Done, the postpone option will now appear in the regular row of buttons. Theopolisme (talk) 17:03, 23 March 2014 (UTC)
{{resolved}}
Last evening I added a comment to a new Afc submission, and I noticed that you added a feature to notify the user. This is great, because new users don't always know about watchlists. Without declining the article I was able to get the editor started on changing the external links into references and wikilinks. A useful addition. —Anne Delong (talk) 14:24, 24 March 2014 (UTC)
{{resolved}}
Today I was told by a user at a Wikiproject that an old Afc submission had been improved and was ready for mainspace. I used the new script to submit the article in the name of the original submitter, who did most of the work. The script worked fine. My next step was to accept the submission, so I therefore clicked on the options link provided, but the "submit" was not on the list. I reloaded the page and then it worked. This wasn't necessary with the old script, but I'm not sure why. Maybe even if the page wasn't visually reloaded, it would have been saved, so maybe the old script rechecked the submit status each time before displaying the options and the new one doesn't. —Anne Delong (talk) 18:28, 24 March 2014 (UTC)
{{resolved}}
The rewrite added two difrent db-templates. See this picture. (t) Josve05a (c) 12:39, 28 March 2014 (UTC)
{{resolved}}
Since the db-g12 can have up to 3 url's, then so should the script and AfC-submission template, to make it easier for the admin when deleting the page. (t) Josve05a (c) 13:06, 28 March 2014 (UTC)
{{resolved}} See this. Is it possible for the default text in the "additional comments" box to not appear by default if you do not wish to leave another comment (and forget to clear the box....) --Mdann52talk to me! 13:24, 28 March 2014 (UTC)
{{resolved}}
Hello again! I used the new script to postpone a db-g13 eligible submission, but it didn't give me an option to leave a comment. Not serious, as I can always leave one separately, but the old script includes this. Since there is a comment option available, maybe this is a design decision; however, postponers are more likely to leave a postponement rational if the comment dialogue box is displayed automatically. —Anne Delong (talk) 10:49, 29 March 2014 (UTC)
Done, now live on enwiki. :) Theopolisme (talk) 14:13, 29 March 2014 (UTC)
{{resolved}}
I used the script to leave a comment on a page that had been moved from a sandbox. Does a cleaning process happen when a comment is left? And, if so, are sandbox templates supposed to be removed as part of the cleaning? —Anne Delong (talk) 00:04, 30 March 2014 (UTC)
This was just an oversight on my part; will be fixed momentarily. Theopolisme (talk) 02:44, 30 March 2014 (UTC)
{{resolved}}
Hello once more, script developer guys... I declined an article as a copyright violation. The script gave me a choice of adding a second URL (although actually I needed to add two more, but I just put them together in the same one). It produced both a decline box and a large speedy deletion box. The second box had all of the URLs correctly listed, but the decline box didn't. Either it should list them all, or it should refer the reader to the speedy deletion box. I don't think the original script produced both boxes; I'm not sure if this is a planned design change or not. —Anne Delong (talk) 12:21, 31 March 2014 (UTC)
{{resolved}} Hi.... aren't you glad you asked me to write? I was declining a submission, and after selecting the decline option and writing some comments, I clicked on the button to complete the decline, but received a "bad token" error. Now, I had just switched from a 3G network to internal wireless; maybe there was a loss of session data, but there is no way for me to tell. Usually when that happens I am given a second chance to save, but in this case I had to retype, so maybe it was another problem. Also the network switch happened before I selected decline from the menu, and think, but can't remember for sure, whether I had just marked as reviewing, or if I did that before switching (sorry). —Anne Delong (talk) 20:32, 31 March 2014 (UTC)
This happens when the page is opened and then there is a loss of session data (e.g. the computer goes to sleep or is inactive for a long time, or like Anne said, a network switch between when you loaded the page -- and we first fetched the edit token, required to save the page -- and when we actually tried to save), which results in the token MediaWiki provides becoming out of date. I'll work on some sort of mechanism for automatically recovering from these errors, probably this weekend (quite busy during the week)... Theopolisme (talk) 00:19, 1 April 2014 (UTC)
{{resolved}}
Hello again. The script is telling me that this article Wikipedia talk:Articles for creation/Madison Eagles has unbalanced ref tags. I have checked line by line through the text, and I can't find the problem. Also, I have context colours turned on, so I should get weird colouring if a tag is missing. I apologize in advance if the script is right and I am just going blind. —Anne Delong (talk) 20:58, 2 April 2014 (UTC)
{{resolved}}
The script is giving me an option to submit my own user page. Is this a feature? I may become famous any day now... —Anne Delong (talk) 13:54, 4 April 2014 (UTC)
I think y'all have gotten rather off-topic here; yes, this is the intended functionality, and I see no reason for adding unnecessary special-casing. As you were, as you were :) Theopolisme (talk) 15:15, 5 April 2014 (UTC)
{{resolved}} Just one more thing - there may be a small bug in the submit process, but I am not sure. This is the second time this has happened, but the first time I assumed it was my error. Check the two diffs and see that a newline has been removed after the ==References==. It was there in the previous edit, and the only thing I did was select submit, and the last submitter option.
{{resolved}} Moved to dropdown. Theopolisme (talk) 22:49, 9 April 2014 (UTC)
The link "Review submission" got broken up in two lines. It might be because I have zoomed ou to 90% of my screen, but if the title would be longer, this would happen. See this picture. (t) Josve05a (c) 12:43, 28 March 2014 (UTC)
{{resolved}} @Theopolisme: I like to check the diff after cleaning a submission, so if a button/link to view the latest diff after cleaning could be included, that would be great. (t) Josve05a (c) 12:32, 7 April 2014 (UTC)
@Josve05a: I've added a "(diff)" link after each "Saved <page>" message...is this helpful? @Technical 13: I feel like wikEdDiff may be overkill in this situation... Theopolisme (talk) 23:58, 10 April 2014 (UTC)
{{resolved}} Make the 'common' section to be "personalized" or learn which reasons I use most, and not 3 "decided" reasons. (t) Josve05a (c) 12:48, 7 April 2014 (UTC)
"Learn which reasons I use most" is not actually too crazy idea...in fact, I rather like it, if only for the programming adventures it might provide...if I have a chance I'll probably work on this, since an "intelligent" script could be pretty nifty :D Theopolisme (talk) 21:51, 7 April 2014 (UTC)
{{resolved}} Having the selector beside the title is a nuisance, because I am constantly highlighting titles to paste them into talk pages. Other text on the line slows me down. I didn't say anything about this before, because I assumed it was temporary. Other than that, I don't see why the new script can't be given out now, as long as the old one is not removed. —Anne Delong (talk) 17:48, 7 April 2014 (UTC)
Including it in the submission template probably would be troublesome for reviewers, especially because submission templates aren't always at the top of the page...and besides, what if the page hasn't yet been submitted?
Anne/Josve/T13, what do you think about something like [5]? Just an idea...still just trying different things out -- that's what a beta is for, after all :) Theopolisme (talk) 21:48, 7 April 2014 (UTC)
@Josve05a, Anne Delong, and Technical 13: I've moved the link back to the dropdown where it was before, as well as set it up to automatically add the string " (old)" after the review links which lead to the other helper script, if they are present. Hope this helps, and thanks for the feedback :) Theopolisme (talk) 23:37, 8 April 2014 (UTC)
{{resolved}} Hello, guys - I like the new position of the script selector, but for some reason my Twinkle tab has moved to the right of the Page tab. Is this a coincidence, or is it connected? It's annoying because if I'm not careful instead of the page history I get CSD. —Anne Delong (talk) 18:59, 9 April 2014 (UTC)
Resolving as unrelated to AFCH, since I can't replicate this. Theopolisme (talk) 16:41, 16 April 2014 (UTC)
{{resolved}} I am used to press alt+s (on Chrome) to save an edit, not it brings up the review-script instead. (Found on User:Andrea3823/sandbox). I want my option to save using this shortcut back! (t) Josve05a (c) 09:09, 9 April 2014 (UTC)
Nice to hear from you Mabdul; long time no see! This is the new AFCH that I've been developing for the past few months (:D); have you had a a chance to try it out? Theopolisme (talk) 22:14, 10 April 2014 (UTC)
{{resolved}} Dear scripties (or I guess in the tradition of Star Trek, scriptors) : I just used the old script and it came up with a warning that there was an unbalanced ref tag. The new script didn't. There really was an unbalanced ref tag. Is this a feature that is not implemented yet, or did it just miss this one? —Anne Delong (talk) 22:54, 9 April 2014 (UTC)
@Anne Delong: I can't replicate this. I copied the contents of the Leo Schmidt page into WT:AFC/sand and am seeing a "The submission contains unclosed <ref> tags" warning. Am I missing something? Thanks, Theopolisme (talk) 16:39, 16 April 2014 (UTC)
{{resolved}} Hello again! While reviewing this draft: Wikipedia talk:Articles for creation/The Walls Have Ears, the script said that there were ref tags but no reflist. True, but the references were showing anyway because there is a "listaref" tag. I haven't seen that one before, but it's apparently legit. —Anne Delong (talk) 15:07, 18 April 2014 (UTC)
When I cleaned up (<<diff) Wikipedia talk:Articles for creation/Oceanhouse Media, Inc. it forgot(?) to remove these. (t) Josve05a (c) 20:53, 19 April 2014 (UTC)
@Josve05a and Technical 13: The helper script had the functionality implemented, but someone modified the template without alerting me a few weeks ago, which resulted in the script missing the modified comment (obviously). I've added a warning at https://en.wikipedia.org/w/index.php?title=Template:AFC_submission/Substdraft&action=edit which should help. Theopolisme (talk) 17:30, 20 April 2014 (UTC)
No, I did not notify them, as there would have been no real point -- the deed was done. "Quickly find a dev"? Since no one else has contributed to the rewrite except me, I'm not sure how helpful that is. But sure, change away. A note on the talk page? Which talk page? Theopolisme (talk) 21:21, 20 April 2014 (UTC)
It forgot this. I don't know if it hasn't updated yet, or if there is something else...I am tired right now when I write this. (t) Josve05a (c) 00:18, 21 April 2014 (UTC)
Yep, the update should be pushed out now. Theopolisme (talk) 21:43, 21 April 2014 (UTC)
{{resolved}} Hello again! I postponed the page Wikipedia talk:Articles for creation/Adrian Derbyshire, which looked fine before, and left a comment. Something has gone wrong with the formatting after the comment. I didn't fix it so you could take a look. —Anne Delong (talk) 03:04, 27 April 2014 (UTC)
<nowiki>
parsing issues). Thanks for noticing this! Theopolisme (talk) 21:04, 28 April 2014 (UTC)
<nowiki>
s that I wasn't aware of. Should be fixed shortly. Again, thanks Anne :) Theopolisme (talk) 22:34, 28 April 2014 (UTC){{resolved}} While tagging for deletion it gives out this line:
Logged speedy deletion nomination of [[ARTICLENAMEHERE]]
What I think it should do is to say:
Logged speedy deletion nomination in [[User:Josve05a/CSD log]]. (diff)
(t) Josve05a (c) 14:46, 28 April 2014 (UTC)
{{resolved}}
When reviewing Tritirachiomycetes, the script told me that I might not see all of the references because there were ref tags after the reflist. This is true, but in this case the format appears to work fine. —Anne Delong (talk) 22:06, 21 April 2014 (UTC)
{{resolved}} My take on the visual interface: The old helper script had a very compact and easy-on-the eyes design. Screen space is at a premium, so I'm hoping that the new giant words, white lettering on black background, and hidden options on the right which I use a lot are temporary while important functional aspects are worked on. I liked the left-justified options in the old interface because they were always in the same location for selection by mouse pointer. —Anne Delong (talk) 22:28, 22 March 2014 (UTC)
@Anne Delong and Technical 13: I've switched from a hover-based reveal to a click-based reveal. I think we should continue investigating alternative methods for displaying the additional options, but for now hopefully this will be clearer. Theopolisme (talk) 17:01, 23 March 2014 (UTC)
{{resolved}}
This time I really wanted to nominate an article for deletion, so I selected the appropriate box. A large yellow notice came up (the words "requesting deletion" were overlapping the words "give feedback) and then it said "working....", but never presented the "done. [Reload]" message. However, when I manually reloaded, the tagging appears to have been done properly and the appropriate notice is on the user's page, so the lack of a reload options seems to be the only problem. In case it makes a difference, it was a draft that was not in English and had never been submitted (grey draft box). —Anne Delong (talk) 03:33, 23 March 2014 (UTC)
@Anne Delong and Technical 13: I'm not sure what is going on. T13, it looks like the ajaxStop event sometimes doesn't fire, but it's difficult to reproduce... will keep y'all posted, though. Theopolisme (talk) 17:05, 23 March 2014 (UTC)
{{resolved}} I ran across a problem when accepting a submission. It appears that the title of the draft was blacklisted because it began with "Lol". (??). Neither the old or the new script identified the problem. I don't know if it's possible for the script to detect if the move was successful, and either read the error message from the move process or check the intended title and report its status, but it would be a helpful feature, because it took me a while to find out what was wrong.
I've just implemented a warning that prevents accepting submissions that are blocked using the TitleBlacklist for the current reviewer. I agree we should discuss better solutions for the future, but for now simply preventing accept seems like a simple intermediate solution. Theopolisme (talk) 17:19, 26 March 2014 (UTC)
{{resolved}} The new release includes "postpone G13" functionality, better edit summaries, click-based toggles instead of hover, title blacklist checking, AfC whitelist support, inline automagical page refreshing after making changes (try it out -- the script now reloads the page content without requiring you to do anything, and without physically "reloading"...look for it during your next review, seriously), and a number of other features and fixes. Bug reports and feature requests encouraged :) Theopolisme (talk) 23:27, 27 March 2014 (UTC)
{{resolved}}
Please make the script automatically mark an article as patrolled when reviewing. (t) Josve05a (c) 13:05, 28 March 2014 (UTC)
Top priority; currently figuring out the best way to implement this. Theopolisme (talk) 14:17, 29 March 2014 (UTC)
Now live on enwiki: When accepting a submission that is not yet patrolled, a checkbox will now appear, unchecked by default, that offers to mark the page as patrolled. This seems quite uncontroversial yet still perfectly functional (@Technical 13 and Hasteur: ?). Theopolisme (talk) 03:42, 30 March 2014 (UTC)
{{resolved}} Hello again (well, you asked for input...) When I select Mark as reviewing or Comment, the script reloads automatically, but doesn't remove the large displayed words which then continue to take up screen space for no reason. If the other options were being displayed, this might make sense, since perhaps the next thing to be done is another reviewing option (although in my case more often it's not; I am more likely to edit the page first). However, since it takes another click to get the options anyway, it's just as easy to get them from the original reviewing link. —Anne Delong (talk) 02:07, 30 March 2014 (UTC)
{{resolved}} I was about to submit an article that I had improved, but the script says it has been previously deleted. There was a link to the deletion discussion - great! Except that it didn't lead to the discussion, but instead to a page about the deletion process. —Anne Delong (talk) 20:52, 2 April 2014 (UTC)
{{resolved}} Hey y'all!
Thanks to everyone who has tested the rewrite over the past month. Your feedback has been invaluable, and by all means please keep providing it.
I'd like to begin to make plans for releasing it (or at least publicizing it) on the WT:AFC talk page (without removing the old script at this point in time). Before that happens, though, my question is simple:
For example, I know Technical 13 had some ideas in #Broken row, above, but that discussion stalled a few days ago. @Anne Delong and Josve05a: as our two biggest beta testers, I'm also very interested in hearing from active reviewers as well.
Thanks! Theopolisme (talk) 11:15, 7 April 2014 (UTC)
{{resolved}}
Hello again - a peripheral topic this time, not a bug. I asked about this on the talk page for the old script, but didn't get a solution.
There has been a lot of talk at Wikipedia talk:WikiProject Articles for creation about the problem of attracting specialist editors to review submissions. Some of us have been notifying Wikiprojects, but this is a slow, manual process. There should be a way for any editor, whether or not he or she has the script installed, to search the queue for items of interest. The "search link" template allows a search string and prefix, for example:
football -REDIRECT prefix:Wikipedia talk:Articles for creation
will show me all of the articles in "Wikipedia talk:Articles for creation" with the word "football" that are not redirects. There are over 1,000. However, I haven't been able to figure out a way to select only the active submissions. The problem seems to be that the Afc templates are transcluded. I can use CatScan to search the categories, but it doesn't have a field for text in the body of the article.
I tried the "search prefix" template, and it makes a nice search box, but doesn't have an option for a default string, so I couldn't even eliminate the redirects.
Is there some characteristic of only the active submissions that could be picked up by the standard search engine? If not, would it be possible to embed one? (I'd suggest the hidden text "Mxyzptlk", but that would be sure to cause trouble.) And then remove it again when the script is reviewed, of course.
As I said, this is not a bug, so if it's not practical, don't worry about it. If there's a way to do this, though, we could create custom searches for the Wikiprojects to make it easy for them to check the active submissions periodically. —Anne Delong (talk) 12:29, 17 April 2014 (UTC)
"Review waiting"
(in quotes) in the search strings, for example. It's not perfect, but you could further fine tune it obviously (so, say, include more of the template text or whatever)... is that at all helpful? As you can see, I'm not too much of a search expert. Theopolisme (talk) 05:28, 18 April 2014 (UTC)
{{resolved}}
Dear script developers: One of the items on this proposal was that the helper script would only function for editors who were on the AfC reviewer's list, it technically feasible, and otherwise would remind users to sign up. Is this practical? —Anne Delong (talk) 10:35, 28 April 2014 (UTC)
I'll need to implement this in the old script... good point (sighs...). Theopolisme (talk) 22:04, 29 April 2014 (UTC)
Hey everyone,
Just a heads up that I had a burst of productivity and wrote a preference management system for the new script. Preferences can be accessed by clicking the "preferences" link next to "give feedback" on the main panel -- right now, there's not that much to customize (in fact, next to nothing) -- but now that the system is in place it will be very easy to add more.
@Technical 13, Anne Delong, and Hasteur: and many others, I'm open to any and all suggestions for features which should be made user configurable -- please feel free to brainstorm here! I've got a few listed here as well, scavenged from previous discussions. Thanks! Theopolisme (talk) 23:26, 23 May 2014 (UTC)